Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: active group field/occupation status #6

Open
castdrian opened this issue Jan 13, 2024 · 3 comments
Open

feat: active group field/occupation status #6

castdrian opened this issue Jan 13, 2024 · 3 comments

Comments

@castdrian
Copy link

firstly lovely project, very thankful for the fact that it is typed as well, ideally it would be nice to have two additional fields on the idol spec:

activeGroup
the idols current group if it exists

occupation:
perhaps an enum that differentiates between SOLOIST and GROUP

@Kagami
Copy link
Member

Kagami commented Jan 14, 2024

Hi!

activeGroup
the idols current group if it exists

Idol might be in two different groups, e.g. Nana from woo!ah! and EL7Z U+P (the second is temporary though). Also subunits count as groups too and in many groups disband_date isn't properly set so it still counts as current idol's group.

You can filter out all groups with current=false, e.g. . as $r | .idols[] | select(.name=="Sakura") as $i | $r.groups[] | select(.members[] | select(.idol_id==$i.id and .current)) | {idol: $i, group: .} click

Maybe we should add temporary: boolean; field for the groups and fix the disband dates so that you can always filter out all non-primary groups of the idol (you can also check if it's not subunit by parent_id==null)? What do you think?

occupation:
differentiates between SOLOIST and GROUP

Oh yeah, I was thinking about how to differentiate non-active idols and idols performing as soloists. Maybe we can have fake group with name something like SOLO and add all soloists there?

Not sure what to do with e.g. Twice or Blackpink idols because a lot of them have released albums as a solo artists but can we actually count them as soloists?

@castdrian
Copy link
Author

I think a placeholder group that says solo is a great idea, personally I would say idols who are still part of a group aren't soloists even if they have released solo music, but since it's your project it's up to you really

@Kagami
Copy link
Member

Kagami commented Jan 14, 2024

idols who are still part of a group aren't soloists

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants