-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dataclass with extension point #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koxudaxi
force-pushed
the
support_dataclass_with_extension_point
branch
from
January 31, 2020 03:20
03897b1
to
fe87afd
Compare
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
============================================
+ Coverage 68.28% 68.87% +0.58%
- Complexity 89 93 +4
============================================
Files 11 12 +1
Lines 637 649 +12
Branches 216 216
============================================
+ Hits 435 447 +12
Misses 93 93
Partials 109 109
Continue to review full report at Codecov.
|
koxudaxi
changed the title
[WIP] Support dataclass with extension point
Support dataclass with extension point
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR supports a native feature to treat
dataclass
variants which feature include typing and inspection with PyCharm.The feature is added in PyCharm since version 2020 EAP or later.
PyCharm provides the feature as an extension point for third-party dataclass variant libraries like
Pydantic
.Thanks to @sproshev
Related Issues
#48
JetBrains/intellij-community#1245