Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve autocompletion for signature #51

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Improve autocompletion for signature #51

merged 3 commits into from
Aug 27, 2019

Conversation

koxudaxi
Copy link
Owner

Detail

The PR appends two features to improve autocompletion for signatures subclasses of pydantic.BaseModel and pydantic.dataclasses.dataclass.

Features

  • Priority showing the fields
    If you enter Ctr + Space or Cmd + Space on model Callers then, Fields are shown on top.
    eg: Model(<here>)
  • Display definition Class
    The information appears right side on the autocompletion list.

ScreenShots

ss2019-08-27 12 21 37

@koxudaxi koxudaxi merged commit 71c2b3d into master Aug 27, 2019
@koxudaxi koxudaxi deleted the improve_completion branch August 27, 2019 04:01
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #51 into master will increase coverage by 1.73%.
The diff coverage is 87.8%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
+ Coverage     78.41%   80.14%   +1.73%     
- Complexity       61       62       +1     
============================================
  Files             6        7       +1     
  Lines           227      267      +40     
  Branches         88       98      +10     
============================================
+ Hits            178      214      +36     
  Misses            1        1              
- Partials         48       52       +4
Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/Pydantic.kt 62.5% <0%> (ø) 0 <0> (ø) ⬇️
...koxudaxi/pydantic/PydanticCompletionContributor.kt 90% <90%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c60d2...9f78cff. Read the comment docs.

@dmontagu
Copy link
Contributor

This is awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants