Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extra init args on baseSetting #276

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

koxudaxi
Copy link
Owner

Related Issues

#274

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #276 (d582a7a) into master (00b58b8) will decrease coverage by 0.27%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
- Coverage     71.25%   70.97%   -0.28%     
- Complexity      224      230       +6     
============================================
  Files            22       22              
  Lines          1343     1368      +25     
  Branches        427      434       +7     
============================================
+ Hits            957      971      +14     
- Misses          150      153       +3     
- Partials        236      244       +8     
Flag Coverage Δ Complexity Δ
unittests 70.97% <57.14%> (-0.28%) 230.00 <5.00> (+6.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/com/koxudaxi/pydantic/PydanticAnnotator.kt 93.33% <0.00%> (ø) 11.00 <0.00> (ø)
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 75.62% <56.00%> (-1.74%) 104.00 <5.00> (+6.00) ⬇️
src/com/koxudaxi/pydantic/Pydantic.kt 72.01% <100.00%> (+0.11%) 0.00 <0.00> (ø)
...koxudaxi/pydantic/PydanticCompletionContributor.kt 80.74% <100.00%> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9696013...d582a7a. Read the comment docs.

@koxudaxi koxudaxi merged commit be5218d into master Apr 16, 2021
@koxudaxi koxudaxi deleted the support_extra_init_args_on_base_setting branch April 16, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant