Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Problem with creating table header links in rails 3.0 #3

Open
chrisstr opened this issue Dec 30, 2010 · 1 comment
Open

Possible Problem with creating table header links in rails 3.0 #3

chrisstr opened this issue Dec 30, 2010 · 1 comment

Comments

@chrisstr
Copy link

I've included the plugin in a rails 3.0 app and it mostly worked as expected. But i have experienced some problems with the table header generation, looks like the ActionView method "link_to" has a problem with the way the options-array is generated by "build_url_params" in sortable_helper.rb.

The solution for me was to change line 57 in sortable_helper.rb from

"return {:action => action, :params => params}"
to
"return {:action => action}.merge(params)"

I did that change via an initializer to prevent touching the plugin and i didn't thoroughly test it, but it works for me. And as far as i checked, it shouldn't create any unwanted side-effects.

@kovacs
Copy link
Owner

kovacs commented Mar 16, 2011

Hey Sorry I just saw this now... cool thanks for the report. I'll check it out when I upgrade my app to rails 3 and put that into the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants