Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation on nightly fails #175

Closed
pitdicker opened this issue Mar 29, 2018 · 4 comments
Closed

Compilation on nightly fails #175

pitdicker opened this issue Mar 29, 2018 · 4 comments

Comments

@pitdicker
Copy link

Because the TryFrom trait is stabilized rust-lang/rfcs#1542
@koute
Copy link
Owner

koute commented Mar 29, 2018

Looks like those have been put into the prelude right away, ugh... this is going to require some extra trickery to work on stable and nightly simultaneously....

Thanks for the report!

@pitdicker
Copy link
Author

This is the relevant rust issue rust-lang/rust#49305

@tirkarthi tirkarthi mentioned this issue Mar 30, 2018
Closed
@tirkarthi
Copy link

This seems to be reverted with the PR rust-lang/rust#49518

@koute
Copy link
Owner

koute commented Apr 3, 2018

Looks like this is resolved. For now. So I'll be closing this issue.

I've already started to work on migrating to the TryFrom/TryInto traits from the stdlib, so hopefully we'll be better prepared next time it's added to the prelude.

@koute koute closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@koute @tirkarthi @pitdicker