Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Test suite with json-schema-benchmark #90

Open
korzio opened this issue Nov 22, 2019 · 3 comments
Open

Sync Test suite with json-schema-benchmark #90

korzio opened this issue Nov 22, 2019 · 3 comments

Comments

@korzio
Copy link
Owner

korzio commented Nov 22, 2019

  1. Ensure test suite is equal to the one used inside the https://github.com/ebdrup/json-schema-benchmark/ repository . Currently https://github.com/json-schema-org/JSON-Schema-Test-Suite is a git dependency inside package.json for the djv project. Inside the https://github.com/ebdrup/json-schema-benchmark/ it is used in a different way - as a git sub module.
  1. Fix tests is some are failing
  2. Understand how the update of benchmark will happen, both in benchmark and djv repository. They should be synced
@korzio
Copy link
Owner Author

korzio commented Nov 29, 2019

Dear @ebdrup

We see that in the json-schema-benchmark repository you use a git submodule for JSON-Schema-Test-Suite dependency.
We see in the github a link to the commit with the SHA 86f965e53dda0b6c57e70ddd726243e1e061cf84 , but we cannot find any reference in the codebase about this specific commit.
We also see that the latest "tagged" version of JSON-Schema-Test-Suite is https://github.com/json-schema-org/JSON-Schema-Test-Suite/commits/2.0.0 and for now djv is compliant with it. But we'd like to go further and adopt latest tests and start working on updated suites. So, our questions are:

  • Where can we find a link to the specific JSON-Schema-Test-Suite commit in the json-schema-benchmark project?
  • What would be the best strategy to run djv tests against? Should it be master branch of the JSON-Schema-Test-Suite repository?

I hope you can point us to the right direction, otherwise please let me know who else can help :)
Thanks in advance

@korzio
Copy link
Owner Author

korzio commented Dec 7, 2019

#92

@korzio
Copy link
Owner Author

korzio commented Dec 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant