Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons appear to be blurry on a Retina MacBook Pro screen #77

Closed
kirill-grouchnikov opened this issue Jul 1, 2020 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@kirill-grouchnikov
Copy link

Running ..\..\gradlew run from apps/sampler-swing on a Retina MacBook Pro shows the demo browsing app, and all the icons appear to be blurry - instead of sharp.

@aalmiray
Copy link
Collaborator

aalmiray commented Sep 9, 2020

I noticed that as well, it may be related to icon size and will have another look. Although the FontIcon class has the following code when creating the image where the icon is drawn

            Graphics2D g2 = (Graphics2D) buffer.getGraphics();
            g2.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
                RenderingHints.VALUE_ANTIALIAS_ON);

@nicolaecismaru
Copy link

The icon is no longer blurry on HiDPI screens if it is painted directly to the Graphics object instead of painting it from the cached BufferedImage buffer.

ikonli-77.patch.zip

@aalmiray
Copy link
Collaborator

Thanks! removing the double-buffering does solve the issue.

@aalmiray aalmiray self-assigned this Apr 21, 2021
@aalmiray aalmiray added the Bug label Apr 21, 2021
@aalmiray aalmiray added this to the 12.3.0 milestone Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants