Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core module identifier spelled wrong in 11.3.5 #59

Closed
dlemmermann opened this issue Feb 26, 2020 · 1 comment
Closed

Core module identifier spelled wrong in 11.3.5 #59

dlemmermann opened this issue Feb 26, 2020 · 1 comment
Assignees
Milestone

Comments

@dlemmermann
Copy link

In version 11.3.5 the "core" module uses the identifier "org.kordamp.iconli.core" instead of "org.kordamp.ikonli.core" (a "c" instead of a "k"). So the spelling, by accident, is correct .... but the code is wrong :-)

In my module-info.java I now have to write:

    requires org.kordamp.iconli.core;
    requires org.kordamp.ikonli.javafx;
    requires org.kordamp.ikonli.materialdesign;
@aalmiray
Copy link
Collaborator

aalmiray commented Mar 12, 2020

Yup, a bummer this was not noticed earlier. Given that changing the module name constitutes a breaking change we'll push this update for 12.0.0 which currently depends on a fix to the gradle modules plugin to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants