Merge Report Aggregator Plugin

[Pfoerd]

First of all: i really appreciate your work on the android fork of gradle-pitest-plugin, it enables us to use mutation testing in our large-scale android setups 😄 .

Could you please merge the "new" PitestAggregatorPlugin to improve support of Multi-module project setups?
It can't be used without modifications because it forces subprojects to have a plugin with id "info.solidsoft.pitest" applied and uses it's extension type.

[koral--]

Sure, I'll try to integrate changes from the parent repo ASAP.

[Pfoerd]

Thanks a lot! :)

[Pfoerd]

@koral-- did you test the Aggregator Plugin? I get a NPE for the charset as it is not set. After exploring the code I think you have to set a charset here to get it work?

It seems that the DirectorySourceLocator mandatory needs it here to read the xml files?

[koral--]

Will check that.

[Pfoerd]

I'm using latest pitest Release 1.9.2, maybe its an incompatibility?

[Pfoerd]

@koral-- After looking a bit deeper into this I think this incompatibility was introduces with 1.8.1 of pitest release about one month ago (see this change)

EDIT: this should be the corresponding open issue in gradle-pitest-plugin: Link

[szpak]

@koral-- After looking a bit deeper into this I think this incompatibility was introduces with 1.8.1 of pitest release about one month ago (see this change)

Good catch @Pfoerd.

Passing the charset will be added in the next version of the plugin, but I wonder @hcoles, if ReportAggregator (being somehow a public API), for backward compatibility, couldn't set a default value "by default", as it is already done in ConfigOption?

[hcoles]

@szpak I'll add some defaults in for the next release.

[Pfoerd]

This is fixed in Pitest 1.9.3, thanks @hcoles

[koral--]

Thanks for the updates.
I assume that I can close this issue then.