From cfddb4ef5b59e8e9a9b437bc60bfbc1dd2c6ab69 Mon Sep 17 00:00:00 2001
From: Scott J Dickerson <sdickers@redhat.com>
Date: Thu, 28 Mar 2024 10:56:21 -0400
Subject: [PATCH] :seedling: Setup CI workflow to use same container as
 Dockerfile

Lookup the "FROM .* as builder" image from the project's
Dockerfile, and use that image to run the CI unit-test job.

This will ensure the unit-test job is using the same container
image that the image builds will be using.  A problem with the
container should show up quickly in the unit-testing.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
---
 .github/workflows/ci-repo.yml | 47 ++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 25 deletions(-)

diff --git a/.github/workflows/ci-repo.yml b/.github/workflows/ci-repo.yml
index abe3ce1dfe..1ada538289 100644
--- a/.github/workflows/ci-repo.yml
+++ b/.github/workflows/ci-repo.yml
@@ -10,31 +10,40 @@ on:
       - "main"
       - "release-*"
 
-env:
-  # Note: This should match the node version(s) used in the base Dockerfile
-  node-version: "18"
-
 jobs:
+  unit-test-lookup-image:
+    runs-on: ubuntu-latest
+    outputs:
+      builder-image: ${{ steps.grepBuilder.outputs.builder }}
+    steps:
+      - uses: actions/checkout@v4
+      - name: Lookup builder image from the project's Dockerfile
+        id: grepBuilder
+        run: |
+          builder=$(grep 'as builder' Dockerfile | sed -e 's/^FROM \(.*\) as builder$/\1/')
+          echo "Builder image: \`$builder\`" >> $GITHUB_STEP_SUMMARY
+          echo "builder=$builder" >> "$GITHUB_OUTPUT"
+
   unit-test:
     runs-on: ubuntu-latest
+    needs: unit-test-lookup-image
+
+    # Use the same container as the Dockerfile's "FROM * as builder"
+    container: ${{ needs.unit-test-lookup-image.outputs.builder-image }}
 
     steps:
       - uses: actions/checkout@v4
 
-      - name: Use Node.js (version "${{ env.node-version }}")
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ env.node-version }}
-          cache: "npm"
-
-      - name: Force install npm@9 to match Dockerfile build container ubi9/nodejs-18:1-88
-        run: npm install -g npm@9
+      # TODO: Setup a cache for npm so it could install faster
+      #       follow actions/setup-node@v4 techniques
 
       - name: Verify package-lock.json
         run: ./scripts/verify_lock.mjs
 
       - name: Install
-        run: npm clean-install --ignore-scripts
+        run: |
+          npm version
+          npm clean-install --ignore-scripts
 
       - name: Lint sources
         run: npm run lint
@@ -44,15 +53,3 @@ jobs:
 
       - name: Test
         run: npm run test -- --coverage --watchAll=false
-
-      - name: Upload to codecov (client)
-        uses: codecov/codecov-action@v4
-        with:
-          flags: client
-          directory: ./*/coverage
-
-      - name: Upload to codecov (server)
-        uses: codecov/codecov-action@v4
-        with:
-          flags: server
-          directory: ./*/coverage