✨ Use build args for the version string #778
Conversation
Signed-off-by: Dylan Murray <dymurray@redhat.com>
dymurray
added
the
cherry-pick/release-0.6
Dockerfile
Outdated
| @@ -15,13 +15,15 @@ FROM quay.io/konveyor/static-report as report | |||
|
|
|||
| FROM registry.access.redhat.com/ubi9/ubi-minimal | |||
| ARG SEED_ROOT | |||
| ARG HUB_VERSION=latest | |||
There was a problem hiding this comment.
@fbladilo this is where we can just template CI_VERSION
There was a problem hiding this comment.
Just a nit, but it is the file is building the hub image so the HUB_ seems redundant.
Dockerfile
Outdated
| COPY --from=builder /opt/app-root/src/auth/roles.yaml /tmp/roles.yaml | ||
| COPY --from=builder /opt/app-root/src/auth/users.yaml /tmp/users.yaml | ||
| COPY --from=builder ${SEED_ROOT}/resources/ /tmp/seed | ||
| COPY --from=report /usr/local/static-report /tmp/analysis/report | ||
|
|
||
| RUN echo "${HUB_VERSION}" >> /etc/hub-build |
There was a problem hiding this comment.
Is this append (>>) desired instead of the overwrite (>) that was previously used to generate this file? Is there any concern where appending could introduce a problem that wouldn't be observed by overwriting?
There was a problem hiding this comment.
It seems safe given it should be a new file creation regardless, but wanted to toss it out there... 😉
There was a problem hiding this comment.
Agreed > would be more correct.
There was a problem hiding this comment.
Fair point; considering the base is always reset I don't think this would be an issue but no reason to append!
Signed-off-by: Dylan Murray <dymurray@redhat.com>
Signed-off-by: Dylan Murray <dymurray@redhat.com>
|
LGTM |
Signed-off-by: Dylan Murray <dymurray@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
Signed-off-by: Dylan Murray <dymurray@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Signed-off-by: Dylan Murray <dymurray@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Dylan Murray <dymurray@redhat.com>
No description provided.