Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format around the first tag in XML isn't preserved. #29

Open
thagikura opened this issue May 23, 2018 · 1 comment
Open

Format around the first tag in XML isn't preserved. #29

thagikura opened this issue May 23, 2018 · 1 comment
Milestone

Comments

@thagikura
Copy link

thagikura commented May 23, 2018

Overview

The format around the first tag in XML isn't preserved.

Description

When I ran this plugin against a project, one of the modified XML file now looks like as follows
The version of the plugin was 0.3.3

<?xml version="1.0" encoding="utf-8"?>
<!--
  ~ Copyright 2018 Google LLC
  ~
  ~ Licensed under the Apache License, Version 2.0 (the "License");
  ~ you may not use this file except in compliance with the License.
  ~ You may obtain a copy of the License at
  ~
  ~     https://www.apache.org/licenses/LICENSE-2.0
  ~
  ~ Unless required by applicable law or agreed to in writing, software
  ~ distributed under the License is distributed on an "AS IS" BASIS,
  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  ~ See the License for the specific language governing permissions and
  ~ limitations under the License.
  --><resources xmlns:tools="http://schemas.android.com/tools">

      <!-- Redacted -->

</resources>

If you look at the starting "resources" tag, the format was changed unwantedly.
The git diff looks like as follows

-  -->
-
-<resources xmlns:tools="http://schemas.android.com/tools">
+  --><resources xmlns:tools="http://schemas.android.com/tools">

It's great if you preserve the original format.

Thanks for the useful plugin by the way!

@konifar
Copy link
Owner

konifar commented May 23, 2018

Thanks for your report!
I'll try to fix this on next release

@konifar konifar added this to the 1.0.0 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants