From 6ca73f22b46360d6cdb5446e15479d7438871e63 Mon Sep 17 00:00:00 2001 From: konifar Date: Sun, 20 May 2018 01:37:45 +0900 Subject: [PATCH] Removed float xml remover --- .../UnusedResourcesRemoverPlugin.groovy | 1 - .../valuetype/FloatXmlValueRemover.groovy | 9 ----- .../valuetype/FloatXmlValueRemoverTest.groovy | 34 ------------------- 3 files changed, 44 deletions(-) delete mode 100644 plugin/src/main/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemover.groovy delete mode 100644 plugin/src/test/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemoverTest.groovy diff --git a/plugin/src/main/groovy/com/github/konifar/gradle/remover/UnusedResourcesRemoverPlugin.groovy b/plugin/src/main/groovy/com/github/konifar/gradle/remover/UnusedResourcesRemoverPlugin.groovy index bf508ca..6d71f12 100644 --- a/plugin/src/main/groovy/com/github/konifar/gradle/remover/UnusedResourcesRemoverPlugin.groovy +++ b/plugin/src/main/groovy/com/github/konifar/gradle/remover/UnusedResourcesRemoverPlugin.groovy @@ -39,7 +39,6 @@ class UnusedResourcesRemoverPlugin implements Plugin { new StyleXmlValueRemover(), new StringXmlValueRemover(), new DimenXmlValueRemover(), - new FloatXmlValueRemover(), new ColorXmlValueRemover(), new IntegerXmlValueRemover(), new BoolXmlValueRemover(), diff --git a/plugin/src/main/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemover.groovy b/plugin/src/main/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemover.groovy deleted file mode 100644 index 24b0144..0000000 --- a/plugin/src/main/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemover.groovy +++ /dev/null @@ -1,9 +0,0 @@ -package com.github.konifar.gradle.remover.remover.valuetype - -class FloatXmlValueRemover extends XmlValueRemover { - - FloatXmlValueRemover() { - super("float", "dimen", "item") - } - -} \ No newline at end of file diff --git a/plugin/src/test/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemoverTest.groovy b/plugin/src/test/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemoverTest.groovy deleted file mode 100644 index e76ef7d..0000000 --- a/plugin/src/test/groovy/com/github/konifar/gradle/remover/remover/valuetype/FloatXmlValueRemoverTest.groovy +++ /dev/null @@ -1,34 +0,0 @@ -package com.github.konifar.gradle.remover.remover.valuetype - -import com.github.konifar.gradle.remover.remover.SearchPattern -import spock.lang.Specification - -class FloatXmlValueRemoverTest extends Specification { - - private XmlValueRemover remover = new FloatXmlValueRemover() - - def "type is valid"() { - expect: - remover.fileType == "float" - remover.resourceName == "dimen" - remover.tagName == "item" - remover.type == SearchPattern.Type.DEFAULT - } - - def "pattern matches"() { - GString pattern = remover.createSearchPattern("size_ratio") - - expect: - XmlValueRemover.isPatternMatched(fileText, pattern) == expected - - where: - fileText | expected - "R.dimen.size_ratio" | true - "@dimen/size_ratio\"" | true - "@dimen/size_ratio<" | true - "R.dimen.size" | false - "@dimen/size_ratio2\"" | false - "@style/size_ratio" | false - } - -} \ No newline at end of file