From a7c2f6d25c9a6de3071a9ddf0193391ef5f6f654 Mon Sep 17 00:00:00 2001 From: Nathan Ellingwood Date: Thu, 15 Jun 2023 11:56:31 -0600 Subject: [PATCH 1/2] Fix for rocblas builds - Rename uploChar to uplo in fillMode for consistency with usage - Dereference uplo in fillMode usage for comparison to char --- blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp b/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp index 1184719138..46a355c088 100644 --- a/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp +++ b/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp @@ -28,7 +28,7 @@ namespace Impl { const int N = static_cast(A_is_lr ? A.extent(0) : A.extent(1)); \ constexpr int one = 1; \ const int LDA = A_is_lr ? A.stride(0) : A.stride(1); \ - rocblas_fill fillMode = (uploChar == 'L' || uploChar == 'l') \ + rocblas_fill fillMode = (*uplo == 'L' || *uplo == 'l') \ ? rocblas_fill_lower \ : rocblas_fill_upper; From f5e2f8254aaa4e5e3dd4caa51f1597098fff4641 Mon Sep 17 00:00:00 2001 From: Nathan Ellingwood Date: Thu, 15 Jun 2023 12:05:12 -0600 Subject: [PATCH 2/2] apply clang-format --- blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp b/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp index 46a355c088..13e2bd21b1 100644 --- a/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp +++ b/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp @@ -28,9 +28,8 @@ namespace Impl { const int N = static_cast(A_is_lr ? A.extent(0) : A.extent(1)); \ constexpr int one = 1; \ const int LDA = A_is_lr ? A.stride(0) : A.stride(1); \ - rocblas_fill fillMode = (*uplo == 'L' || *uplo == 'l') \ - ? rocblas_fill_lower \ - : rocblas_fill_upper; + rocblas_fill fillMode = (*uplo == 'L' || *uplo == 'l') ? rocblas_fill_lower \ + : rocblas_fill_upper; #define KOKKOSBLAS2_DSYR_ROCBLAS(LAYOUT, EXEC_SPACE, MEM_SPACE, \ ETI_SPEC_AVAIL) \