Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate makefile with-spaces option #98

Closed
mndevec opened this issue Oct 13, 2017 · 1 comment
Closed

generate makefile with-spaces option #98

mndevec opened this issue Oct 13, 2017 · 1 comment
Assignees
@crtrott @mndevec
Labels
enhancement InDevelop

Comments

@mndevec
Copy link
Contributor

mndevec commented Oct 13, 2017

When no memory space is provided to generate makefile, it adds HostSpace and instantiates it. Same way with memkind option.

However, when with-spaces option is used; it overwrites memory spaces. As a result HostSpace is not instantiated. Currently whenever we provide memory space, we need to explicity provide HostSpace to instantiate it.

It would be better to fix this, even when a memory space is provided without HostSpace, I think it should be instantiated.
@mndevec mndevec changed the title generata makefile with-spaces option generate makefile with-spaces option Oct 13, 2017
@ndellingwood
Copy link
Contributor

This was done by @crtrott, SHA cd5d9fb in 2017. Marking InDevelop and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

@mndevec mndevec

Labels
enhancement InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crtrott @ndellingwood @mndevec