Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial SpMV fails on Kokkos-dev2 nightly #896

Closed
lucbv opened this issue Feb 17, 2021 · 3 comments
Closed

Serial SpMV fails on Kokkos-dev2 nightly #896

lucbv opened this issue Feb 17, 2021 · 3 comments
Assignees
Labels

Comments

@lucbv
Copy link
Contributor

lucbv commented Feb 17, 2021

The new serial specialization in Kokkos Kernels fails to compile in our nightly Jenkins build.
The error reported is related to a memset call that fails on Kokkos::complex see below:

03:26:59 /home/jenkins/slave/workspace/KokkosKernels_KokkosDev2_CUDA110_GCC92_cpp17/kokkos-kernels/src/sparse/impl/KokkosSparse_spmv_impl.hpp:344:7: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘using non_const_value_type = using non_const_value_type = using non_const_value_type = using non_const_value_type = std::remove_const<Kokkos::complex<double> >::type’ {aka ‘class Kokkos::complex<double>’}; use assignment or value-initialization instead [-Werror=class-memaccess]
03:26:59   344 |         memset(y_ptr, 0, sizeof(typename YVector::value_type)*nrow);
03:26:59       |       ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

should not be to annoying to fix : )

@kyungjoo-kim
Copy link
Contributor

umm.... does this only happen on cuda gcc build ? Is it also reproduceable from just gcc serial build ? I am not sure why it complains bout the sizeof(object). It should work but the solution is easy. I will submit an PR for this soon.

@kyungjoo-kim
Copy link
Contributor

PR #898

@lucbv
Copy link
Contributor Author

lucbv commented Feb 22, 2021

This has now been fixed, thanks @kyungjoo-kim for working in this : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants