Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/check robustness of the IOUtils.hpp random matrix generators #682

Open
brian-kelley opened this issue Apr 9, 2020 · 0 comments
Open
Assignees

Comments

@brian-kelley
Copy link
Contributor

PRs #661 and #678 helped a lot, but we should still go though all the functions and make sure they handle all reasonable inputs correctly. For example, the fix I did to kk_sparseMatrix_generate didn't make it into kk_generate_diagonally_dominant_sparse_matrix, so it's possible other functions still have issues.

Example (noticed by @ndellingwood): In a later PR probably should add a check that ncols > 0 in case someone calls the routine with ncols == 0 (lines 197-200).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant