Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking error in tpl things #282

Closed
kyungjoo-kim opened this issue Aug 28, 2018 · 4 comments
Closed

Linking error in tpl things #282

kyungjoo-kim opened this issue Aug 28, 2018 · 4 comments

Comments

@kyungjoo-kim
Copy link
Contributor

The problem is that we have two definition to BLAS fortran interface. We should hide the tpl header files.

/ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/teuchos/numerics/src/Teuchos_BLAS_wrappers.hpp:177:84: error: conflicting declaration of C function ‘void dscal_(const int*, const double*, double*, const int*)’
 void PREFIX DSCAL_F77(const int* n, const double* alpha, double *x, const int* incx);
                                                                                    ^
In file included from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/kokkos-kernels/src/blas/impl/KokkosBlas1_scal_spec.hpp:357:0,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:47,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/kokkos-kernels/src/sparse/impl/KokkosSparse_spmv_impl.hpp:48,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/kokkos-kernels/src/sparse/impl/KokkosSparse_spmv_spec.hpp:53,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/kokkos-kernels/src/sparse/KokkosSparse_spmv.hpp:51,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/kokkos-kernels/src/sparse/KokkosSparse.hpp:58,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/tpetra/core/src/Tpetra_CrsMatrix_decl.hpp:64,
                 from /ascldap/users/kyukim/Work/lib/trilinos/build/tpetra/pullrequest/packages/tpetra/core/src/Tpetra_CrsMatrix.hpp:1,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/moertel/src/mortar/Moertel_ManagerT.hpp:66,
                 from /ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/moertel/src/mortar/Moertel_ManagerT.cpp:51:
/ascldap/users/kyukim/Work/lib/trilinos/kyukim/packages/kokkos-kernels/src/impl/tpls/KokkosBlas1_scal_tpl_spec_decl.hpp:50:33: note: previous declaration ‘double dscal_(const int*, const double*, const double*, const int*)’
 extern "C" double               dscal_( const int* N, const double* alpha,
@crtrott
Copy link
Member

crtrott commented Aug 31, 2018

Ok so something like #ifndef TEUCHOS_BLAS or whatever Teuchos' define is

@mhoemmen
Copy link
Contributor

mhoemmen commented Sep 2, 2018

We should hide the tpl header files.

YES PLEASE :-)

@crtrott
Copy link
Member

crtrott commented Sep 25, 2018

Maybe fixed somewhere? But Kyungjoo will double check.

@kyungjoo-kim
Copy link
Contributor Author

PR #314 includes the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants