Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KokkosBatched warnings #259

Closed
srajama1 opened this issue Jun 15, 2018 · 6 comments
Closed

KokkosBatched warnings #259

srajama1 opened this issue Jun 15, 2018 · 6 comments
Assignees

Comments

@srajama1
Copy link
Contributor

Number of warnings in KokkosBatched

KokkosBatched_LU_Serial_Internal.hpp(59) (col. 22): warning: calling a host function("KokkosBatched::Experimental::RealPart ") from a host device function("KokkosBatched::Experimental::SerialLU_Internal< ::KokkosBatched::Experimental::Algo::Level3::Unblocked> ::invoke ") is not allowed

....................../KokkosBatched_AddRadial_Internal.hpp(58): warning: calling a host
function("KokkosBatched::Experimental::RealPart ") from a host device function("Kokkos::parallel_for<int, ::> ") is not allowed

@kyungjoo-kim
Copy link
Contributor

kyungjoo-kim commented Jun 15, 2018

What is the context ? We cannot push a code if we have warnings as we use "Werror". So, I am in doubt that this comes from kokkoskernels compiling.

@crtrott
Copy link
Member

crtrott commented Jun 15, 2018

The Werror only applies to the host compilation part. I.e. warnings issued by the device side will not trigger a failure.

@kyungjoo-kim
Copy link
Contributor

I also think that you use an outdated code. RealPart should not be used as @vqd8a fixes in pr #236

@kyungjoo-kim
Copy link
Contributor

Anyway, I confirmed that those warnings are generated from our testing code. I will fix them soon. It is interesting that device code warnings are not considered as failures. Good to know.

@ndellingwood
Copy link
Contributor

Assuming this was fixed with #243

@srajama1
Copy link
Contributor Author

srajama1 commented Sep 6, 2018

Is this in master ? If not can we leave it open with InDevelop tag till we do a master update ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants