Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Kernel Labels for KokkosBlas #239

Closed
csiefer2 opened this issue May 16, 2018 · 4 comments
Closed

More Kernel Labels for KokkosBlas #239

csiefer2 opened this issue May 16, 2018 · 4 comments
Assignees
@kyungjoo-kim
Labels
enhancement InDevelop
Milestone
August Release 3.0

Comments

@csiefer2
Copy link
Contributor

Some of the kernels in KokkosBlas have labels (e.g. "KokkosBlas::update<0,b,c>") but some do not (e.g. the stuff in V_MultFunctor), leaving downstream developers stuck with staring at the mangled names and guessing.

Can somebody do a pass over the KokkosBlas and ensure that these commonly use functions have kernel labels? Thanks!
@srajama1
Copy link
Contributor

I don't want to block 2.7 promotion for this (assuming this is not such a pain), we will take care of this in 2.8.

@csiefer2
Copy link
Contributor Author

No objections here.

@crtrott crtrott added this to the August Release 3.0 milestone May 29, 2018
@ndellingwood ndellingwood mentioned this issue Dec 4, 2018
Closed
@kyungjoo-kim
Copy link
Contributor

All routines in KokkosKernels now have profiling labels #359

@ndellingwood ndellingwood mentioned this issue Dec 12, 2018
Merged
@ndellingwood
Copy link
Contributor

PR #359 merged with added labels.

@ndellingwood ndellingwood mentioned this issue Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyungjoo-kim kyungjoo-kim

Labels
enhancement InDevelop
Projects
None yet
Milestone
August Release 3.0
Development

No branches or pull requests
5 participants
@kyungjoo-kim @csiefer2 @crtrott @srajama1 @ndellingwood