Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=ON in CUDA, complex ON, ETI ON build #176

Closed
mhoemmen opened this issue Mar 12, 2018 · 4 comments

Comments

@mhoemmen
Copy link
Contributor

See discussion here: trilinos/Trilinos#2141

@ndellingwood
Copy link
Contributor

@mhoemmen I have PR #149 up to check that CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=ON for the CUDA, complex ON, ETI ON build, and if not tell users to enable this.

From trilinos/Trilinos#2141 it seems the decision is to let users enable this CMake option rather than set it as default due to potential issues depending on combos of OS, CMake version and compiler see NOTE bottom of TribitsBuildReference

Is PR #149 sufficient to resolve this issue?

@ndellingwood
Copy link
Contributor

Adding @srajama1 to discussion.

@mhoemmen
Copy link
Contributor Author

@ndellingwood I left some comments on PR #149 that address your questions. I would prefer that kokkos-kernels check for now, as long as that works for all tested host compiler options in CUDA builds.

@srajama1
Copy link
Contributor

Based on the comments in the above referenced Trilinos issue and the comment about gfortran and CMake, let us just request the user to set it and reconfigure. I will add it to my list of annoyances and complain in about it on bad days :)

We should at least update the limited "documentation" we have so whoever is enabling complex knows this ahead. Let us do that and push this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants