Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FORCE improperly unsetting KokkosKernels_ENABLE_ALL_COMPONENTS in repeated cmake #1690

Closed
cwpearson opened this issue Feb 18, 2023 · 3 comments
Closed

FORCE improperly unsetting KokkosKernels_ENABLE_ALL_COMPONENTS in repeated cmake #1690

cwpearson opened this issue Feb 18, 2023 · 3 comments
Assignees
@cwpearson

Comments

@cwpearson
Copy link
Contributor

kokkos-kernels/cmake/kokkoskernels_components.cmake

Line 54 in 6d73c14

SET(KokkosKernels_ENABLE_ALL_COMPONENTS OFF CACHE BOOL "" FORCE)

Consider:

  1. Configure Kokkos kernels with KokkosKernels_ENABLE_ALL_COMPONENTS=ON
  2. This enables each individual component
  3. Configure Kokkos Kernels again (cmake ...)
  4. Since individual components are enabled and FORCE is present, KokkosKernels_ENABLE_ALL_COMPONENTS is now off
  5. Tests / Perf Tests stop building

I think FORCE should just be removed from this line
@cwpearson cwpearson self-assigned this Feb 18, 2023
@cwpearson
Copy link
Contributor Author

@lucbv ?

@cwpearson cwpearson changed the title FORCE improperly unsetting KokkosKernels_ENABLE_ALL_COMPONENTS in repeated cmake FORCE improperly unsetting KokkosKernels_ENABLE_ALL_COMPONENTS in repeated cmake Feb 18, 2023
@cwpearson
Copy link
Contributor Author

In progress: #1691

@cwpearson
Copy link
Contributor Author

Fixed in #1691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwpearson cwpearson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwpearson