Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmp.gesv_{double,mrhs_double,complex_double,mrhs_complex_double) failures w/ GCC 10.2.0 & c++17, with blas tpl enabled #1523

Closed
e10harvey opened this issue Sep 12, 2022 · 10 comments
Assignees
Labels

Comments

@e10harvey
Copy link
Contributor

Example of failure output with gcc 10.2.0 & c++17:

/path/to/kokkos-kernels/unit_test/blas/Test_Blas_gesv.hpp:121: Failure
Value of: true
Expected: test_flag
Which is: false

Similar failures are printed for the other 3 tests.

Reproducer

With kokkos@4477a25ebe12b655cd5da273eec4ab954fbf32d5 and kokkos-kernels@0f5c8cc57f366a902cf415b97898d2ed88de9d56:

source /etc/profile.d/modules.sh
module purge
module load cmake/3.19.3 gcc/10.2.0 openblas/0.3.13/gcc/10.2.0

$KOKKOSKERNELS_PATH/cm_generate_makefile.bash --with-devices=OpenMP,Serial --arch=SKX --compiler=$GCC_PATH/bin/g++ --cxxflags="-O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized " --cxxstandard="17" --ldflags=""   --kokkos-path=$KOKKOS_PATH --kokkoskernels-path=$KOKKOSKERNELS_PATH --with-scalars='double,complex_double' --with-ordinals=int --with-offsets=int,size_t --with-layouts=LayoutLeft --with-tpls=blas --user-blas-path=$OPENBLAS_ROOT/lib --user-lapack-path=$OPENBLAS_ROOT/lib --user-blas-lib=blas --user-lapack-lib=lapack --extra-linker-flags=-lgfortran,-lm --with-options= --with-cuda-options=   --no-examples
@e10harvey e10harvey added the bug label Sep 12, 2022
@e10harvey
Copy link
Contributor Author

@vqd8a : Would you have time to take a look?

@vqd8a
Copy link
Contributor

vqd8a commented Sep 12, 2022

@e10harvey: I will look at it.

@vqd8a
Copy link
Contributor

vqd8a commented Sep 20, 2022

@e10harvey I think there are some issues with the current openblas/0.3.13/gcc/10.2.0 on blake when using c++17. I observe that the gesv tests only pass with OMP_NUM_THREADS <=4, otherwise the gesv tests fail.

When I tried these tests with OpenBLAS 0.3.13 and higher versions installed in my home directory on blake (gcc 10.2.0, c++17), these tests pass with any OMP_NUM_THREADS.

Can we request for newer versions of OpenBLAS on blake?

@e10harvey
Copy link
Contributor Author

Can we request for newer versions of OpenBLAS on blake?

Ok, I filed a ticket for this.

@lucbv
Copy link
Contributor

lucbv commented Oct 11, 2022

@e10harvey for some reason despite PR #1562 the build is not using openblas 0.3.20 as seen in Jenkins output and reproducer instruction. This CI is currently failing for that reason.

@lucbv
Copy link
Contributor

lucbv commented Oct 11, 2022

Note that I tested with the new openblas and the tests are passing with it, it's just not picked up by the script.

@lucbv
Copy link
Contributor

lucbv commented Oct 12, 2022

Never mind, I found my issue...

@vqd8a
Copy link
Contributor

vqd8a commented Nov 22, 2022

@e10harvey Can we close this issue since we had a newer version of OpenBLAS on blake and the tests passed?

@e10harvey
Copy link
Contributor Author

Yes, this can be closed.

@vqd8a
Copy link
Contributor

vqd8a commented Nov 22, 2022

Thanks @e10harvey

@vqd8a vqd8a closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants