Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small error in KokkosBatched_Gemm_Serial_Imp.hpp with SerialGemm<Trans::Transpose,*,*> #147

Closed
kliegeois opened this issue Jan 26, 2018 · 4 comments

Comments

@kliegeois
Copy link
Contributor

kliegeois commented Jan 26, 2018

It seems that in kokkos-kernels/src/batched/KokkosBatched_Gemm_Serial_Impl.hpp, when the matrix A is transposed, the code is currently using A.dimension_1() to get the number k instead of A.dimension_0().

The error seems to be in all the different combinations of the other template arguments (i.e. whether or not B is transposed and for CompactMKL, Blocked, and Unblocked).

@kyungjoo-kim

@kyungjoo-kim
Copy link
Contributor

@kliegeois Thanks. You are right. The code is tested and used only for square blocks. So, the error does not pop up so far. I will fix it soon.

@kyungjoo-kim kyungjoo-kim self-assigned this Jan 26, 2018
@srajama1
Copy link
Contributor

srajama1 commented Sep 5, 2018

Ping

@kyungjoo-kim
Copy link
Contributor

#258 fixed this. done.

@srajama1
Copy link
Contributor

srajama1 commented Sep 6, 2018

Reopening it, and adding indevelop tag. We will close it when we do the master update. Otherwise it is hard to keep track of what are the fixes we did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants