From 57e161de47855f1bc085de8740b85250ce25892f Mon Sep 17 00:00:00 2001 From: Brian Kelley Date: Fri, 16 Dec 2022 20:11:07 -0700 Subject: [PATCH] Fix #1631 Revert one line from #1620 which changed CrsMatrix::values_type (a 1D view) to be default_layout instead of LayoutRight. This seemed totally reasonable (the graph's rowptrs/entries already used default_layout), but the change makes spmv give wrong answers with Sacado PCE or MPVector as the scalar type. --- sparse/src/KokkosSparse_CrsMatrix.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sparse/src/KokkosSparse_CrsMatrix.hpp b/sparse/src/KokkosSparse_CrsMatrix.hpp index 7a6459d88e..dda08faba9 100644 --- a/sparse/src/KokkosSparse_CrsMatrix.hpp +++ b/sparse/src/KokkosSparse_CrsMatrix.hpp @@ -426,7 +426,8 @@ class CrsMatrix { //! Nonconst version of the type of row offsets in the sparse matrix. typedef typename row_map_type::non_const_value_type non_const_size_type; //! Kokkos Array type of the entries (values) in the sparse matrix. - typedef Kokkos::View + typedef Kokkos::View values_type; //! Const version of the type of the entries in the sparse matrix. typedef typename values_type::const_value_type const_value_type;