Make WinP Debuggable #36
Conversation
| echo No target version specified, will determine it from POM | ||
| REM TODO: Apply some MADSKILLZ to do it without the temporary file? | ||
| call mvn -q -Dexec.executable="cmd.exe" -Dexec.args="/c echo ${project.version}" --non-recursive org.codehaus.mojo:exec-maven-plugin:1.3.1:exec > version.txt | ||
| for /f "delims=" %%x in (version.txt) do set version=%%x |
There was a problem hiding this comment.
Yes, I already regret I wrote it in Batch
|
@reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
There was a problem hiding this comment.
🐝 Looks reasonable as far as I understand it - though my batchfile is a bit rusty, so could be missing something.
I think the build.cmd could be titled "writing a makefile in batch using labels and gotos." Watch out for raptors - ;-)
|
@reviewbybees done Batch was definitely a wrong choice, I have never planned to make it complex. Makes sense to consider powershell for the next big refactoring anyway. |
|
Merging to get the CI changes applied |
Idea of this change is to provide a debuggable version of WinP, which allows attaching debugger to java process utilizing it in order to debug the native part.
build.cmdto take more parameters