Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcards in project key parameter #2

Closed
poznachowski opened this issue Oct 21, 2016 · 4 comments
Closed

Support wildcards in project key parameter #2

poznachowski opened this issue Oct 21, 2016 · 4 comments

Comments

@poznachowski
Copy link
Contributor

Proposition:
Add support for wildcards in project key parameter. I find option of asterisk '*' at the end of the key sufficient.

Rationale:
Currently the plugin takes project key (ex. com.company:project) exactly as is.

If someone would like to make analysis on branches (via sonar.branch parameter), he would need to make appropriate changes in the plugin configuration (project key with branch would look like: com.company:project:branch_name). Considering some flow with short-term branches it would be really annoying.

If asterisk wildcard is implemented, I can specify com.company:project:* to send analysis of each projects` branches to a single Slack channel.

@poznachowski poznachowski changed the title Support wildcards in project key parameter. Support wildcards in project key parameter Oct 21, 2016
@kogitant
Copy link
Owner

Hi,
excellent idea. I'll look into this.

@poznachowski
Copy link
Contributor Author

I already submit PR for this: #3 :)

@kogitant
Copy link
Owner

Pull request merged, 2.0 release https://github.com/kogitant/sonar-slack-notifier-plugin/releases/tag/2.0 includes this. Thanks for the contribution!

@lemmebee
Copy link

Hi, I'm having a problem using project key parameter and configuring slack channel! Could you please help me with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants