Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retype SN to BigInt #184

Closed
vikiival opened this issue Jan 10, 2024 · 1 comment · Fixed by #185
Closed

Retype SN to BigInt #184

vikiival opened this issue Jan 10, 2024 · 1 comment · Fixed by #185
Assignees
@roiLeo
Labels
enhancement New feature or request

Comments

@vikiival
Copy link
Member

Describe the feature

Currently we have a lot of bugs connected to sorting by sn because it is string

Expected outcome

Change sn from String to BigInt (
pub const MAX: u32 = 4_294_967_295u32)

cc @roiLeo can u ? 🥺
Do not forget to codegen and migrations
@maige-app maige-app bot added the enhancement New feature or request label Jan 10, 2024
@roiLeo roiLeo self-assigned this Jan 10, 2024
@roiLeo
Copy link
Contributor

roiLeo commented Jan 10, 2024

cc @roiLeo can u ? 🥺 Do not forget to codegen and migrations

EoD or tomorrow

@roiLeo roiLeo mentioned this issue Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roiLeo roiLeo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔧 NFTEntity sn type roiLeo/stick
2 participants
@roiLeo @vikiival