Can't catch thrown error

[Zefau]

Hi,

thanks for you library. I'm using it for an ioBroker module implementation (see https://github.com/Zefau/ioBroker.roomba).

In the course of my implementation I'm struggling to catch the error thrown in lib/v2/local.js at row 30:

dorita980/lib/v2/local.js

Line 30 in df31a27

throw e;

Try-catch-block fails catching the error, e.g. following code will NOT work:

try
{
	robot = new Roomba.Local(adapter.config.username, library.decode(settings.decode.key, adapter.config.password), adapter.config.ip); // username, password, ip
}
catch(err)
{
	adapter.log.debug(err.message);
	return;
}

My suggestion is to not throw the error and leave error-handling it to the end-point-implementation.

Thanks
Zefau

[koalazak]

I see the problem. But Im afraid of change that and break current implementations. Maybe we can merge this change with a major version update. But that require some addicional changes in readme and package.json.
PRs are welcome! :p
thanks

[Zefau]

yeah I agree. Are you working on any changes at the moment?
I'm using dorita for an ioBroker implementation (see https://github.com/Zefau/ioBroker.roomba). In the course of that, I would like to support you in the development of this library if you need any help?

[koalazak]

thanks @Zefau
I have pending the cloud implementation for v2 firmwares
take a look if you want: #25