Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic release #523

Closed
stojanovic opened this issue Oct 12, 2015 · 10 comments
Closed

Semantic release #523

stojanovic opened this issue Oct 12, 2015 · 10 comments
Assignees

Comments

@stojanovic
Copy link
Contributor

Since Koa is now using semver, it's probably a good idea to consider using semantic-release too.

What would Koa get with it:

  • Automatic semver control
  • Release changelog
  • Break detection
  • Automatic npm release

What's need to be updated:

  • Installing semantic-release (one time only, and it's simple)
  • Improving commit messages so they can work with semantic-release and changelog generator

It supports updating old releases too, ie. Koa is on 2.x and you want to update 1.x with some important update.

Also, another there's another cool tool that can be used with Koa: greenkeeper.io

@tejasmanohar
Copy link
Member

👍 for semantic-release

@jonathanong jonathanong self-assigned this Oct 13, 2015
@jonathanong
Copy link
Member

i do wanna setup greenkeeper. i'd need to look more into semantic-release

@stojanovic
Copy link
Contributor Author

If you need more info ping me.
Both are really good tools.

@pensierinmusica
Copy link

+1 for having a changelog

@tj
Copy link
Member

tj commented Dec 13, 2015

@pensierinmusica
Copy link

Thanks @tj! Where do I find changelog and usage information for Koa v2.x?

@tj
Copy link
Member

tj commented Dec 13, 2015

I think the 2.x was moved back into a separate branch instead of master https://github.com/koajs/koa/blob/v2.x/History.md

master for latest makes sense to me but I think people were pull-requesting against the wrong branch or something

@pensierinmusica
Copy link

Is there any explanation I can find about:

  • What is being changed from 1.x to 2.x, why, and what is the performance difference
  • How 2.x works
  • What are best practices to convert from 1.x to 2.x
  • What modules support 2.x

Thanks!

@tj
Copy link
Member

tj commented Dec 13, 2015

Good question! I haven't seen any migration docs around but the new Readme sort of highlights the change. It's not obvious that its the only thing that changed but basically just the middleware signature:

https://github.com/koajs/koa/tree/v2.x#example

Which was made because async/await effectively replaces generators, which was actually our intent from the very beginning, but generators were the first thing enabling a similar experience.

https://github.com/koajs/koa/tree/v2.x#example-with-async-functions-babel-required

@jonathanong
Copy link
Member

i don't think it's worth setting up and having everyone follow the rules. publishing also takes 5 seconds and happens once every few months. it's not something that needs to be optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants