Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can koa-convert be updated #1323

Closed
zavr-1 opened this issue Apr 18, 2019 · 6 comments
Closed

Can koa-convert be updated #1323

zavr-1 opened this issue Apr 18, 2019 · 6 comments
Milestone
v3.0.0

Comments

@zavr-1
Copy link

zavr-1 commented Apr 18, 2019

Currently, koa depends on 2 koa-compose, one v3 and one v4. The v3 is coming from the old koa-convert, and it is pulling the blue-bird. Can this be fix now?
Screenshot 2019-04-18 at 08 15 04

https://github.com/koajs/convert/pull/11/files

Best
@fl0w fl0w added the wontfix label Apr 18, 2019
@fl0w
Copy link
Contributor

fl0w commented Apr 18, 2019

This can't be fixed until Koa 3 is released because the removal of bluebird is a breaking change (thus requires semver major release).

@fl0w fl0w closed this as completed Apr 18, 2019
@fl0w
Copy link
Contributor

fl0w commented Apr 18, 2019

Actually, lets keep this open.
Ref: #1114

@fl0w fl0w reopened this Apr 18, 2019
@fl0w fl0w added this to the v3.0.0 milestone Apr 18, 2019
@fl0w fl0w removed the wontfix label Apr 18, 2019
@zavr-1
Copy link
Author

zavr-1 commented Apr 18, 2019

ok thanks! While ^4 is in engines it's a semver indeed. But so what's happened here 7bd82ac?

@zavr-1 zavr-1 mentioned this issue Apr 18, 2019
Open
@fl0w
Copy link
Contributor

fl0w commented Apr 25, 2019

Yea I don't know. The decision was made that it was worth it.

My personal take on this is to NOT do/remove anything because compose will be removed in next version of Koa anyway. It's not worth possibly breaking applications IMO.

Others might disagree though.

@3imed-jaberi 3imed-jaberi mentioned this issue Jul 21, 2020
Merged
11 tasks
@niftylettuce
Copy link
Contributor

Waiting on koa-convert ownership to be given to me by @gyson or npm staff. Then I will release new major release per koajs/convert#13.

@niftylettuce
Copy link
Contributor

v2.0.0 released https://github.com/koajs/convert/releases/tag/v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@fl0w @niftylettuce @zavr-1