Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dark theme loop labels not visible #837

Merged
merged 1 commit into from
May 28, 2019
Merged

fix dark theme loop labels not visible #837

merged 1 commit into from
May 28, 2019

Conversation

jnnnnn
Copy link
Contributor

@jnnnnn jnnnnn commented May 14, 2019

  • fix loop label text forced to black, ignoring styles
  • fix styles that were being ignored

the fix in pictures

Here is an example of the problem: VSCode's markdown preview has a dark background (when a dark theme is active). The loop text is not readable for the dark theme because it is black on a dark background.

The fix in pictures: https://imgur.com/a/kRwll6B

* fix loop label text forced to black, ignoring styles
* fix styles that were being ignored
@jnnnnn jnnnnn marked this pull request as ready for review May 14, 2019 01:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.256%

Totals Coverage Status
Change from base Build 716: 0.0%
Covered Lines: 2051
Relevant Lines: 3755

💛 - Coveralls

@knsv
Copy link
Collaborator

knsv commented May 28, 2019

Thanks! Good to get that fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants