Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI output #536

Merged
merged 9 commits into from
May 31, 2017
Merged

Conversation

gibson042
Copy link
Contributor

  • Always use verbosity-aware CLI logging
  • Include file paths in CLI log output

@@ -75,7 +75,7 @@ files.forEach(function (file) {
var oDOM
var svgContent

console.log('ready to execute png: ' + filename + '.png ')
log('ready to execute: ' + file)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this change makes execution completely silent without --verbose. If that's undesirable, we could use console.log for "ready to execute" and "saved" messages.

@tylerlong
Copy link
Collaborator

Do you know why Travis CI build failed?

It was OK: https://travis-ci.org/knsv/mermaid/builds/225268042

@gibson042
Copy link
Contributor Author

Ugh, it's the thing I had to update for running tests locally:

This application failed to start because it could not find or load the Qt platform plugin "offscreen".

Available platform plugins are: phantom.

Fixed now (I hope).

@gibson042
Copy link
Contributor Author

It failed again, but this one is probably out of my hands:

No binary for Chrome browser on your platform.
Please, set "CHROME_BIN" env variable.

@gibson042
Copy link
Contributor Author

Nevermind, I fixed it per Travis CI documentation. 🙌

@tylerlong tylerlong merged commit e08496d into mermaid-js:master May 31, 2017
mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
Bumps [@sveltejs/adapter-static](https://github.com/sveltejs/kit/tree/HEAD/packages/adapter-static) from 1.0.0-next.21 to 1.0.0-next.22.
- [Release notes](https://github.com/sveltejs/kit/releases)
- [Changelog](https://github.com/sveltejs/kit/blob/master/packages/adapter-static/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/kit/commits/HEAD/packages/adapter-static)

---
updated-dependencies:
- dependency-name: "@sveltejs/adapter-static"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants