Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty search queries should be allowed #40

Closed
zaidkazi opened this issue Mar 6, 2021 · 1 comment
Closed

Empty search queries should be allowed #40

zaidkazi opened this issue Mar 6, 2021 · 1 comment
Assignees
@nhathiwala
Labels
bug Something isn't working

Comments

@zaidkazi
Copy link

zaidkazi commented Mar 6, 2021

In query.dart it is specified that

"If the text is empty or absent, the search will match every object in your index."

Further the library prevents an empty query string. This directly falls against Algolia's pinned suggestion returns which allows you to pin items to return when an empty search is provided.

I don't believe restricting the query to non empty string is the right functionality.
@zaidkazi zaidkazi added the bug Something isn't working label Mar 6, 2021
@zaidkazi zaidkazi mentioned this issue Mar 6, 2021
Closed
@nhathiwala
Copy link
Member

Resolved this bug in version 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhathiwala nhathiwala

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zaidkazi @nhathiwala