Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacks needs to be sourced without the vendor directory #221

Closed
Tracked by #134
cardil opened this issue Sep 7, 2022 · 1 comment · Fixed by #222
Closed
Tracked by #134

Hacks needs to be sourced without the vendor directory #221

cardil opened this issue Sep 7, 2022 · 1 comment · Fixed by #222
Assignees

Comments

@cardil
Copy link
Contributor

cardil commented Sep 7, 2022

Currently, the hack scripts are being sourced from vendor/ directory. To stop relying on hack being in vendor we need a different way to provide the scripts to the projects.

There were at least two proposals:

  1. Sync the hack scripts to projects using a robot, preferably using git subtree to keep the separation. (@upodroid idea)
  2. Embed Bash scripts withing some hack binary. That binary, when executed, will extract them to a temporary directory, and provide the path to the scripts, so they could be sourced. (@cardil idea)
@cardil cardil self-assigned this Sep 7, 2022
@cardil
Copy link
Contributor Author

cardil commented Sep 7, 2022

We'll try the 2nd proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant