Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get image sha in building phase instead of pushing phase #2070

Closed
gauron99 opened this issue Nov 6, 2023 · 7 comments
Closed

Get image sha in building phase instead of pushing phase #2070

gauron99 opened this issue Nov 6, 2023 · 7 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@gauron99
Copy link
Contributor

gauron99 commented Nov 6, 2023

Im writing this as a follow up to #1962 to separate the PRs.

Currently, image sha is got after Push. (after image is pushed to registry) but a better place for it would be to right after the image is built - cleaning up this process.

are you willing to work on this?

yes

Copy link
Contributor

github-actions bot commented Feb 5, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2024
@gauron99
Copy link
Contributor Author

gauron99 commented Feb 5, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
@gauron99
Copy link
Contributor Author

gauron99 commented May 6, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
@gauron99 gauron99 self-assigned this May 6, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 5, 2024
@gauron99 gauron99 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2024
@gauron99
Copy link
Contributor Author

gauron99 commented Nov 5, 2024

since the pushing to cluster itself is what "creates" the sha, current approach is currently best ROI, closing atm. Might reopen in the future

@gauron99 gauron99 closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Next to ✅ Done in Functions WG Roadmap Nov 5, 2024
@gauron99 gauron99 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
@gauron99 gauron99 moved this from ✅ Done to ❄ Icebox in Functions WG Roadmap Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
Status: ❄ Icebox
Development

No branches or pull requests

1 participant