From 8da959a55977e83154e2f927f53a023ad0a4e868 Mon Sep 17 00:00:00 2001 From: Scott Nichols Date: Thu, 23 Jul 2020 11:35:43 -0700 Subject: [PATCH] remove reconciled normal event from subscriptions --- pkg/reconciler/subscription/subscription.go | 6 +----- pkg/reconciler/subscription/subscription_test.go | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/pkg/reconciler/subscription/subscription.go b/pkg/reconciler/subscription/subscription.go index 5e3add48770..d9e94ea25fa 100644 --- a/pkg/reconciler/subscription/subscription.go +++ b/pkg/reconciler/subscription/subscription.go @@ -62,10 +62,6 @@ var ( v1ChannelGVK = v1.SchemeGroupVersion.WithKind("Channel") ) -func newReconciledNormal(namespace, name string) pkgreconciler.Event { - return pkgreconciler.NewEvent(corev1.EventTypeNormal, "SubscriptionReconciled", "Subscription reconciled: \"%s/%s\"", namespace, name) -} - func newChannelWarnEvent(messageFmt string, args ...interface{}) pkgreconciler.Event { return pkgreconciler.NewEvent(corev1.EventTypeWarning, channelReferenceFailed, messageFmt, args...) } @@ -117,7 +113,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, subscription *v1beta1.Su return event } - return newReconciledNormal(subscription.Namespace, subscription.Name) + return nil } func (r *Reconciler) FinalizeKind(ctx context.Context, subscription *v1beta1.Subscription) pkgreconciler.Event { diff --git a/pkg/reconciler/subscription/subscription_test.go b/pkg/reconciler/subscription/subscription_test.go index 73ec2b94470..b785e2b9203 100644 --- a/pkg/reconciler/subscription/subscription_test.go +++ b/pkg/reconciler/subscription/subscription_test.go @@ -208,9 +208,6 @@ func TestAllCases(t *testing.T) { }, Key: testNS + "/" + subscriptionName, WantErr: false, - WantEvents: []string{ - Eventf(corev1.EventTypeNormal, "SubscriptionReconciled", `Subscription reconciled: "testnamespace/testsubscription"`), - }, WantStatusUpdates: []clientgotesting.UpdateActionImpl{{ Object: NewSubscription(subscriptionName, testNS, WithSubscriptionUID(subscriptionUID),