Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for ApiServerSource node selector #7615

Closed
Cali0707 opened this issue Jan 23, 2024 · 1 comment · Fixed by #7627
Closed

Add e2e test for ApiServerSource node selector #7615

Cali0707 opened this issue Jan 23, 2024 · 1 comment · Fixed by #7627
Assignees
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request

Comments

@Cali0707
Copy link
Member

Problem
After #7584 is merged, we should add an e2e test to verify that it is working correctly.

Persona:
Which persona is this feature for?

Exit Criteria
An e2e test in the rekt folder which verifies that the node selector works. My initial thoughts would be a test that:

  1. Adds a label to one of the nodes in the cluster
  2. Created an ApiServerSource which has the nodeselector set to select for that label
  3. Gets the pod(s) associated with the ApiServerSource deployment and verifies that they are all on the correct node.

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)
Add any other context about the feature request here.

@sadath-12
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants