Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using underlying input channels audience as Parallels audience #7295

Closed
creydr opened this issue Sep 25, 2023 · 6 comments · Fixed by #7431
Closed

Support using underlying input channels audience as Parallels audience #7295

creydr opened this issue Sep 25, 2023 · 6 comments · Fixed by #7431
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Sep 25, 2023

As the Eventing OIDC feature track describes, Addressables (and thus Parallels) need to announce their audience in .status.address.audience. As an implementation detail, a Parallels address points to a Channel (which is an Addressable too and thus has an Audience). Therefor an Parallels audience should be equals to its input channels Audience.

In particular the Parallel controller should:

  • Set the Parallels Audience (.status.address.audience) to the same value as its input channels Audience (.status.address.audience)

Additional Information:

@creydr creydr added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 25, 2023
@EraKin575
Copy link
Contributor

I wanna work on this

@creydr
Copy link
Member Author

creydr commented Sep 26, 2023

@EraKin575 happy to hear that.
Just assign the issue to yourself (via /assign or click on assign yourself)

@EraKin575
Copy link
Contributor

/assign

@creydr
Copy link
Member Author

creydr commented Oct 18, 2023

Hello @EraKin575,
as #7187 is done, this should be ready to be worked on.

@creydr
Copy link
Member Author

creydr commented Oct 24, 2023

Hello @EraKin575,
do you have a rough ETA for a PR for this?

@creydr
Copy link
Member Author

creydr commented Nov 6, 2023

@EraKin575 I am going to unassign this issue, as I haven't heard anything on this, so this can be picked up by another contributor.
Feel free to reassign it to you, when you are planning to work on it again soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants