Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exposing the Audience of a Sequence #7185

Closed
creydr opened this issue Aug 16, 2023 · 3 comments
Closed

Support exposing the Audience of a Sequence #7185

creydr opened this issue Aug 16, 2023 · 3 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Aug 16, 2023

As the Eventing OIDC feature track describes, Addressables (and thus Sequences) need to announce their audience in .status.address.audience in the format GROUP/KIND/NAMESPACE/NAME (e.g. flows.knative.dev/sequence/myns/mysequence).

In particular the sequence controller should:

Additional Information:

@creydr creydr added kind/TBD Parked issue that required triaging/revisit in a near future. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 16, 2023
@creydr creydr changed the title [DRAFT] Support exposing the Audience of a Sequence Support exposing the Audience of a Sequence Sep 5, 2023
@creydr creydr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed kind/TBD Parked issue that required triaging/revisit in a near future. labels Sep 5, 2023
@CodesbyUnnati
Copy link

/assign

@creydr
Copy link
Member Author

creydr commented Sep 22, 2023

Hello @CodesbyUnnati,
thanks for taking this. I just wanted to ask, if you're still planning to work on this? In #7237 we did this for the broker, so this might help you to get started (especially the changes in the pkg/reconciler/broker/broker.go might be useful)

@creydr
Copy link
Member Author

creydr commented Oct 4, 2023

@CodesbyUnnati we can close this in favor of #7294, as we will use the channels audience as the sequences audience.

@creydr creydr closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants