Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Event Filtering: Add rekt test for "All" filter #7119

Closed
5 tasks
Cali0707 opened this issue Jul 27, 2023 · 6 comments · Fixed by #7212
Closed
5 tasks

New Event Filtering: Add rekt test for "All" filter #7119

Cali0707 opened this issue Jul 27, 2023 · 6 comments · Fixed by #7212
Assignees
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Problem
To expand the rekt tests of the new event filters, we should create a rekt test of the "Al" filter

Exit Criteria
A rekt test using an "All" filter which has:

  • an Exact filter
  • a Not filter
  • a Prefix filter
  • a Suffix filter
  • a CESQL filter

The test should then send 6 events, one which corresponds to each filter and one which should not match any filter. The test should verify that the events which should be matched are delivered to the sink and that the remaining event is not.

Time Estimate (optional):
How many developer-days do you think this may take to resolve? `

Additional context (optional)
#5204

@Cali0707
Copy link
Member Author

/area test-and-release
/triage accepted

@Rahul-Kumar-prog
Copy link
Contributor

Hey @Cali0707 I would like to work on this can I take this?

@Cali0707
Copy link
Member Author

Cali0707 commented Aug 2, 2023

@Rahul-Kumar-prog my bad for marking this ready to work, it is still not ready until after #7135 is merged. How about I ping you here when this is ready to be worked on and we can see if you want it then?

@Rahul-Kumar-prog
Copy link
Contributor

Rahul-Kumar-prog commented Aug 2, 2023

yeah sure @Cali0707, till then can you give me any other issue. in which I have to work with test cases.

@Cali0707
Copy link
Member Author

Cali0707 commented Aug 2, 2023

@Rahul-Kumar-prog you can always filter issues by labels. For example, in the eventing kafka broker: https://github.com/knative-extensions/eventing-kafka-broker/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Ftest

@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 14, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants