Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerated EventType names not unique enough #7097

Closed
Cali0707 opened this issue Jul 18, 2023 · 3 comments · Fixed by #7160
Closed

Autogenerated EventType names not unique enough #7097

Cali0707 opened this issue Jul 18, 2023 · 3 comments · Fixed by #7160
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Describe the bug
The current solution for autogenerated EventType names is not unique enough, leading to EventTypes which should be created not being created.

Expected behavior
Every new EventType to be seen by the AutoCreateEventType handler should have a new EventType created and stored.

To Reproduce
If #7089 is not merged, then send two events to a broker with the same name and namespace, where name + namespace is longer than ~10chars.

If #7089 is merged, then send two events to a channel or broker where the first ~10chars of the event.Type() are the same.

@Cali0707 Cali0707 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 18, 2023
@Cali0707 Cali0707 moved this to 📋 Backlog in Event Discovery Jul 19, 2023
@pierDipi pierDipi added the triage/accepted Issues which should be fixed (post-triage) label Jul 20, 2023
@pierDipi pierDipi moved this from 📋 Backlog to 🔖 Ready in Event Discovery Jul 20, 2023
@pierDipi
Copy link
Member

cc @matzew @dsimansk any thoughts here?

@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2023

If #7089 is merged, then send two events to a channel or broker where the first ~10chars of the event.Type() are the same.

Given the PR is merged, we are in this case. How about taking the latter portion of event.Type() string as a priority. The types can be quiet lenghty with repetitive org, domain, package names. How about taking the last 10-20 chars as a base for the name?

@dsimansk
Copy link
Contributor

dsimansk commented Aug 9, 2023

/assign

@dsimansk dsimansk moved this from 🔖 Ready to 👀 In review in Event Discovery Aug 9, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Event Discovery Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants