Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brokers status deadLetterUri is not been updated #5787

Closed
gabo1208 opened this issue Oct 5, 2021 · 2 comments · Fixed by #5793
Closed

Brokers status deadLetterUri is not been updated #5787

gabo1208 opened this issue Oct 5, 2021 · 2 comments · Fixed by #5793
Assignees

Comments

@gabo1208
Copy link
Member

gabo1208 commented Oct 5, 2021

Problem
Brokers and Triggers have the same status property: status.deadLetterSinkUri

In Trigger's Spec is clear how it should behave and when to update it. In the Broker's spec is not even mentioned.
I think we should decide between:

  • Removing status.deadLetterSinkUri from the Broker's status (don't know if that is a good decision, if anyone can give a little bit more context about this it'll be helpful :))
  • Fixing Brokers status behavior to update the status.deadLetterSinkUri when its appropriate and to add this behavior to the Broker's spec so its clear for everyone and consistent with other specs (like Subscriptions and Triggers)

Persona:
All

Exit Criteria
Reach a decision between both options for the status.deadLetterSinkUri and implement it.

Additional context (optional)
Add any other context about the feature request here.

@gabo1208
Copy link
Member Author

gabo1208 commented Oct 6, 2021

As commented here, we are going to fix the brokers spec and code to make a MUST resolving the DLQ ref and updating the status.deadLetterSinUri with the resolved URI in the process.

@benmoss
Copy link
Member

benmoss commented Oct 6, 2021

/assign @gabo1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants