Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] API for pingsources.sources.knative.dev is v1 #4928

Closed
5 of 7 tasks
n3wscott opened this issue Feb 22, 2021 · 4 comments
Closed
5 of 7 tasks

[1.0] API for pingsources.sources.knative.dev is v1 #4928

n3wscott opened this issue Feb 22, 2021 · 4 comments
Assignees
@lionelvillard
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone
Backlog

Comments

@n3wscott
Copy link
Contributor

n3wscott commented Feb 22, 2021 •
edited by lionelvillard
Loading

The following work needs to be validated for pingsources.sources.knative.dev to be ready for 1.0:

  • pingsources.sources.knative.dev is served v1 by default
  • Previous served versions are deprecated and removed according to the Knative API process.
  • v1 OpenAPI schema in CRD is complete.
  • pingsources.sources.knative.dev has a validating webhook with 100% coverage according to its spec.
    • for creation
    • for mutation
  • pingsources.sources.knative.dev has a defaulting webhook with 100% coverage according to its spec.
@lberk lberk added this to the Backlog milestone Mar 1, 2021
@slinkydeveloper slinkydeveloper added kind/good-first-issue Denotes an issue ready for a new contributor. and removed kind/good-first-issue Denotes an issue ready for a new contributor. labels Mar 10, 2021
@lionelvillard lionelvillard self-assigned this Apr 26, 2021
@lionelvillard
Copy link
Member

I'll look at adding PingSource v1 API.

@lionelvillard lionelvillard mentioned this issue Apr 28, 2021
Merged
5 tasks
@lionelvillard
Copy link
Member

default webhook has 100% coverage

@lionelvillard
Copy link
Member

same for validation webhook

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lionelvillard lionelvillard

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@lberk @lionelvillard @slinkydeveloper @n3wscott