Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail in goroutine after TestBrokerAsMiddleware/Setup has completed #4637

Closed
pierDipi opened this issue Dec 8, 2020 · 5 comments · Fixed by knative-extensions/reconciler-test#96
Closed

Fail in goroutine after TestBrokerAsMiddleware/Setup has completed #4637

pierDipi opened this issue Dec 8, 2020 · 5 comments · Fixed by knative-extensions/reconciler-test#96
Assignees
@slinkydeveloper @vaikas
Labels
area/test-and-release Test infrastructure, tests or release kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.20.0

Comments

@pierDipi
Copy link
Member

pierDipi commented Dec 8, 2020 •
edited
Loading

Describe the bug

Upgrading dependencies brings a bug in TestBrokerAsMiddleware: #4622

=== RUN   TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event
=== PAUSE TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event
=== CONT  TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event
2020/12/08 01:55:33 eventing.knative.dev/v1, Resource=brokers customname is addressable: http://broker-ingress.knative-eventing-e4mmywinri.svc.cluster.local/rekt-jwtefgkk/customname
        --- FAIL: TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event (240.00s)
panic: Fail in goroutine after TestBrokerAsMiddleware/Setup has completed [recovered]
	panic: Fail in goroutine after TestBrokerAsMiddleware/Setup has completed

goroutine 357 [running]:
testing.tRunner.func1.1(0x2277c40, 0xc00019a8a0)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:999 +0x461
testing.tRunner.func1(0xc000b6e120)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1002 +0x606
panic(0x2277c40, 0xc00019a8a0)
	/root/.gvm/gos/go1.14.12/src/runtime/panic.go:975 +0x3e3
testing.(*common).Fail(0xc0005d77a0)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:671 +0x1fc
testing.(*common).Fail(0xc0005d78c0)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:665 +0x156
testing.(*common).FailNow(0xc0005d78c0)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:693 +0x39
testing.(*common).Fatalf(0xc0005d78c0, 0x25b0a5a, 0x33, 0xc00000e260, 0x2, 0x2)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:789 +0x9e
knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertAtLeast(0xc0005e1f80, 0x1, 0xc000962358, 0x1, 0x1, 0x38f69c8, 0x3e, 0xc0006962c8)
	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:159 +0x323
knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertInRange(0xc0005e1f80, 0x1, 0x1, 0xc000962358, 0x1, 0x1, 0xc0000b2cd0, 0x43f548, 0x8)
	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:169 +0xb1
knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertExact(0xc0005e1f80, 0x1, 0xc000962358, 0x1, 0x1, 0x3d, 0xc000938e08, 0x3d)
	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:199 +0x99
knative.dev/eventing/test/rekt/features.BrokerAsMiddleware.func2(0x2a8ff40, 0xc0007004b0, 0xc000b6e120)
	/home/prow/go/src/knative.dev/eventing/test/rekt/features/middleware_feature.go:63 +0x1c0
knative.dev/reconciler-test/pkg/feature.parallelizeStep.func1(0x2a8ff40, 0xc0007004b0, 0xc000b6e120)
	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/feature/collapse.go:74 +0x79
knative.dev/reconciler-test/pkg/environment.(*MagicEnvironment).Test.func1.1(0xc000b6e120)
	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/environment/magic.go:168 +0x201
testing.tRunner(0xc000b6e120, 0xc000c29bf0)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1050 +0x1ec
created by testing.(*T).Run
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1095 +0x538

Expected behavior

No failures after the test finishes.

To Reproduce

Run TestBrokerAsMiddleware many times.

Knative release version
devel

Additional context
@pierDipi pierDipi added the kind/bug Categorizes issue or PR as related to a bug. label Dec 8, 2020
@lberk lberk added area/test-and-release Test infrastructure, tests or release priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 14, 2020
@lberk lberk added this to the v0.20.0 milestone Dec 14, 2020
@lberk
Copy link
Member

lberk commented Dec 14, 2020

@n3wscott In case you're bored while on vacation :)

@pierDipi pierDipi mentioned this issue Dec 15, 2020
Merged
@pierDipi pierDipi mentioned this issue Jan 7, 2021
Merged
@vaikas
Copy link
Contributor

vaikas commented Jan 13, 2021

Still failing.

I'll take a look

https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/4727/pull-knative-eventing-integration-tests/1349302296709697536

=== RUN   TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event
=== PAUSE TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event
=== CONT  TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event
        --- FAIL: TestBrokerAsMiddleware/Assert/[Stable/MUST]broker_as_middleware_deliver_an_event (240.00s)
panic: Fail in goroutine after TestBrokerAsMiddleware/Setup has completed [recovered]
	panic: Fail in goroutine after TestBrokerAsMiddleware/Setup has completed

goroutine 255 [running]:
testing.tRunner.func1.1(0x2289cc0, 0xc000d824d0)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:999 +0x461
testing.tRunner.func1(0xc0008e8240)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1002 +0x606
panic(0x2289cc0, 0xc000d824d0)
	/root/.gvm/gos/go1.14.12/src/runtime/panic.go:975 +0x3e3
testing.(*common).Fail(0xc0007fdc20)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:671 +0x1fc
testing.(*common).Fail(0xc0007fdd40)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:665 +0x156
testing.(*common).FailNow(0xc0007fdd40)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:693 +0x39
testing.(*common).Fatalf(0xc0007fdd40, 0x25c760d, 0x33, 0xc000844320, 0x2, 0x2)
	/root/.gvm/gos/go1.14.12/src/testing/testing.go:789 +0x9e
knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertAtLeast(0xc0007976e0, 0x1, 0xc000010a68, 0x1, 0x1, 0x391ac18, 0x3e, 0xc000917288)
	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:159 +0x323
knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertInRange(0xc0007976e0, 0x1, 0x1, 0xc000010a68, 0x1, 0x1, 0xc000897cd0, 0x43f548, 0x8) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:169 +0xb1 knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertExact(0xc0007976e0, 0x1, 0xc000010a68, 0x1, 0x1, 0x3d, 0xc0004c4478, 0x3d) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:199 +0x99 knative.dev/eventing/test/rekt/features.BrokerAsMiddleware.func2(0x2aa97c0, 0xc000918480, 0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/test/rekt/features/middleware_feature.go:63 +0x1c0 knative.dev/reconciler-test/pkg/feature.parallelizeStep.func1(0x2aa97c0, 0xc000918480, 0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/feature/collapse.go:74 +0x79 knative.dev/reconciler-test/pkg/environment.(*MagicEnvironment).Test.func1.1(0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/environment/magic.go:168 +0x201 testing.tRunner(0xc0008e8240, 0xc000831260) 	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1050 +0x1ec created by testing.(*T).Run 	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1095 +0x538 | knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertInRange(0xc0007976e0, 0x1, 0x1, 0xc000010a68, 0x1, 0x1, 0xc000897cd0, 0x43f548, 0x8) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:169 +0xb1 knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertExact(0xc0007976e0, 0x1, 0xc000010a68, 0x1, 0x1, 0x3d, 0xc0004c4478, 0x3d) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:199 +0x99 knative.dev/eventing/test/rekt/features.BrokerAsMiddleware.func2(0x2aa97c0, 0xc000918480, 0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/test/rekt/features/middleware_feature.go:63 +0x1c0 knative.dev/reconciler-test/pkg/feature.parallelizeStep.func1(0x2aa97c0, 0xc000918480, 0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/feature/collapse.go:74 +0x79 knative.dev/reconciler-test/pkg/environment.(*MagicEnvironment).Test.func1.1(0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/environment/magic.go:168 +0x201 testing.tRunner(0xc0008e8240, 0xc000831260) 	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1050 +0x1ec created by testing.(*T).Run 	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1095 +0x538
-- | --
knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertInRange(0xc0007976e0, 0x1, 0x1, 0xc000010a68, 0x1, 0x1, 0xc000897cd0, 0x43f548, 0x8) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:169 +0xb1 knative.dev/reconciler-test/pkg/eventshub.(*Store).AssertExact(0xc0007976e0, 0x1, 0xc000010a68, 0x1, 0x1, 0x3d, 0xc0004c4478, 0x3d) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/eventshub/event_info_store.go:199 +0x99 knative.dev/eventing/test/rekt/features.BrokerAsMiddleware.func2(0x2aa97c0, 0xc000918480, 0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/test/rekt/features/middleware_feature.go:63 +0x1c0 knative.dev/reconciler-test/pkg/feature.parallelizeStep.func1(0x2aa97c0, 0xc000918480, 0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/feature/collapse.go:74 +0x79 knative.dev/reconciler-test/pkg/environment.(*MagicEnvironment).Test.func1.1(0xc0008e8240) 	/home/prow/go/src/knative.dev/eventing/vendor/knative.dev/reconciler-test/pkg/environment/magic.go:168 +0x201 testing.tRunner(0xc0008e8240, 0xc000831260) 	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1050 +0x1ec created by testing.(*T).Run 	/root/.gvm/gos/go1.14.12/src/testing/testing.go:1095 +0x538

 

@vaikas vaikas self-assigned this Jan 13, 2021
This was referenced Jan 13, 2021
Merged
Merged
@pierDipi pierDipi mentioned this issue Feb 11, 2021
Closed
@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Feb 17, 2021 •
edited
Loading

/assign

I'm looking at it too, 2 pair of eyes never hurt 😄

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Feb 17, 2021 •
edited
Loading

Ok I may have found the problem, it's in the reconciler test execution

@slinkydeveloper slinkydeveloper mentioned this issue Feb 17, 2021
Merged
@slinkydeveloper
Copy link
Contributor

Check this out knative-extensions/reconciler-test#96

@slinkydeveloper slinkydeveloper mentioned this issue Feb 17, 2021
Closed
@pierDipi pierDipi mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slinkydeveloper slinkydeveloper

@vaikas vaikas

Labels
area/test-and-release Test infrastructure, tests or release kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging a pull request may close this issue.

Context cancelling should be tied to the single test execution slinkydeveloper/reconciler-test
4 participants
@lberk @slinkydeveloper @vaikas @pierDipi