Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PingSource leverages v2/adapter client to support ceOverrides Extensions #4488

Closed
capri-xiyue opened this issue Nov 9, 2020 · 2 comments
Closed

PingSource leverages v2/adapter client to support ceOverrides Extensions #4488

capri-xiyue opened this issue Nov 9, 2020 · 2 comments
Assignees
@lberk
Labels
area/sources kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Backlog

Comments

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Nov 9, 2020 •
edited
Loading

Problem
Currently, pingsource relies on setting the ceOverrides.Extensions in adapter by itself (#3331). It doesn't rely on v2/adapter client to support ceOverrides Extensions. PingSource need to leverage v2/adapter client to support ceOverrides Extensions like what ApiServerSource does(#4477)

Persona:
PingSource leverages v2/adapter client to support ceOverrides Extensions

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.
@grantr grantr added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/sources and removed kind/feature-request labels Nov 16, 2020
@grantr grantr added this to the Backlog milestone Nov 16, 2020
@lberk lberk self-assigned this Nov 17, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2021
@lionelvillard
Copy link
Member

PingSource cannot leverage v2/adapter client to support ceOverrides Extensions because the client is shared by all PingSource instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lberk lberk

Labels
area/sources kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@grantr @lberk @lionelvillard @capri-xiyue