Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ApiServerSource v1 the stored version and add a migration tool #4189

Closed
capri-xiyue opened this issue Oct 1, 2020 · 3 comments · Fixed by #4655
Closed

Make ApiServerSource v1 the stored version and add a migration tool #4189

capri-xiyue opened this issue Oct 1, 2020 · 3 comments · Fixed by #4655
Assignees
Labels
area/api area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Oct 1, 2020

Problem
In 0.19, we promoted ApiServerSource to v1.
This is to track that we should make v1 the storage version for 0.20, and we should add a migration tool for it.
Similar to: https://github.com/knative/eventing/blob/master/config/pre-install/v0.16.0/storage-version-migration.yaml.
(May need to avoid using pre-install and try to use post-install)

Persona:
Which persona is this feature for?

Exit Criteria
ApiServerSource in v1 and able to migrate

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
#4166

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@lberk
Copy link
Member

lberk commented Oct 5, 2020

@capri-xiyue are you aware of anything that require the need for a pre-install job? We're trying to avoid those for upcoming releases, instead, focusing on only using post-installs. Thanks!

@lberk lberk added this to the v0.20.0 milestone Oct 5, 2020
@lberk lberk added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 5, 2020
@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Oct 5, 2020

@capri-xiyue are you aware of anything that require the need for a pre-install job? We're trying to avoid those for upcoming releases, instead, focusing on only using post-installs. Thanks!

Based on my understanding, https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#upgrade-existing-objects-to-a-new-stored-version, it looks like the upgrade of storage version can be done as a post-installs.
I was just following the previous upgrade procedure when I created this issue.

@pierDipi
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants