Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/health doesn't properly implement K8s lifecycle #3912

Closed
mattmoor opened this issue Aug 22, 2020 · 0 comments · Fixed by #3917
Closed

pkg/health doesn't properly implement K8s lifecycle #3912

mattmoor opened this issue Aug 22, 2020 · 0 comments · Fixed by #3917
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@mattmoor
Copy link
Member

Describe the bug
I noticed that eventing has:
https://github.com/knative/eventing/blob/master/pkg/health/probes.go

This blindly responds to liveness and readiness probes with "200 OK", which is fine for things coming up, but it doesn't properly implement lame ducking, which is critical to avoid dropped requests during scale down or rollouts.

Expected behavior

We have libraries for handling kubelet probes in PKG, use those and extend them as appropriate: https://github.com/knative/pkg/blob/d5c09d2aef18eaabbb9ce3ac71a487288ca542aa/network/handlers/drain.go#L78

cc @pierDipi @vaikas @tcnghia

@mattmoor mattmoor added the kind/bug Categorizes issue or PR as related to a bug. label Aug 22, 2020
@vaikas vaikas self-assigned this Aug 24, 2020
@grantr grantr added this to the Backlog milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants