Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a post-install step that deletes the Deprecated deployments. #3225

Closed
vaikas opened this issue May 28, 2020 · 3 comments · Fixed by #3439
Closed

Add a post-install step that deletes the Deprecated deployments. #3225

vaikas opened this issue May 28, 2020 · 3 comments · Fixed by #3439
Assignees
Labels
kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@vaikas
Copy link
Contributor

vaikas commented May 28, 2020

Problem
As part of the #3212 we discussed different ways to clean up the old Deployments. Currently the PR turns the old Deployments to replicas = 0.
Perhaps we should add a post-install job that would actually clean those up properly? Seems like a bigger issue, so opening up an issue to discuss this.

Persona:
Operator

Exit Criteria
Once we have a good upgrade story that we all agree on + implementation.

Time Estimate (optional):
2-3

Additional context (optional)
Add any other context about the feature request here.

@n3wscott
Copy link
Contributor

+1 on : I think we should delete the deployments in a post-install script and drop the files from the repo.

@lberk lberk added this to the v0.16.0 milestone Jun 1, 2020
@lberk
Copy link
Member

lberk commented Jun 1, 2020

We might also want to make sure we track

  • SA's
  • Deployments
  • CM's

@lberk lberk added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 1, 2020
@lberk lberk modified the milestones: v0.16.0, v0.16.0-M1 Jun 1, 2020
@n3wscott
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants